Checkstyle Results

The following document contains the results of Checkstyle 10.7.0 with sun_checks.xml ruleset.

Summary

Files	Info	Warnings	Errors
9	0	0	284

Files

File	I	W	E
example/Main.java	0	0	6
example/Model.java	0	0	20
example/View.java	0	0	121
example/ViewEnglish.properties	0	0	1
money/Money.java	0	0	21
money/MoneyBag.java	0	0	46
money/SimpleMoney.java	0	0	33
reflection/ShowClass.java	0	0	36

Rules

Category	Rule	Violations	Severity
blocks	RightCurly	2	Error
coding	MagicNumber	12	Error
design	DesignForExtension	6	Error
	HideUtilityClassConstructor	1	Error
javadoc	JavadocMethod	25	Error
	JavadocPackage	3	Error
	JavadocStyle	7	Error
	JavadocVariable	16	Error
	MissingJavadocMethod	2	Error
misc	FinalParameters	79	Error
naming	LocalFinalVariableName	1	Error
regexp	RegexpSingleline format: "\s+$" maximum: "0" message: "Line has trailing spaces." minimum: "0"	2	Error
sizes	LineLength fileExtensions: "java"	40	Error
whitespace	MethodParamPad	69	Error
	NoWhitespaceAfter	1	Error
	NoWhitespaceBefore	2	Error
	OperatorWrap	2	Error
	WhitespaceAfter	9	Error
	WhitespaceAround	5	Error

Details

example/Main.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocPackage	Missing package-info.java file.	1
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	14
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	15
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	16
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	23
Error	misc	FinalParameters	Parameter stage should be final.	23

example/Model.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	17
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	20
Error	sizes	LineLength	Line is longer than 80 characters (found 106).	21
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	22
Error	sizes	LineLength	Line is longer than 80 characters (found 87).	23
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	24
Error	javadoc	JavadocStyle	First sentence should end with a period.	27
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	30
Error	misc	FinalParameters	Parameter language should be final.	30
Error	javadoc	JavadocMethod	Expected @param tag for 'language'.	30
Error	javadoc	JavadocStyle	First sentence should end with a period.	36
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	39
Error	misc	FinalParameters	Parameter value should be final.	39
Error	javadoc	JavadocMethod	Expected @param tag for 'value'.	39
Error	whitespace	NoWhitespaceAfter	'!' is followed by whitespace.	40
Error	javadoc	JavadocStyle	First sentence should end with a period.	46
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	49
Error	misc	FinalParameters	Parameter observer should be final.	49
Error	javadoc	JavadocMethod	Expected @param tag for 'observer'.	49
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	56

example/View.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	48
Error	sizes	LineLength	Line is longer than 80 characters (found 113).	49
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	49
Error	whitespace	WhitespaceAround	'+' is not followed by whitespace.	49
Error	whitespace	WhitespaceAround	'+' is not preceded with whitespace.	49
Error	whitespace	WhitespaceAround	'+' is not followed by whitespace.	49
Error	whitespace	WhitespaceAround	'+' is not preceded with whitespace.	49
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	50
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	53
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	54
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	55
Error	javadoc	JavadocStyle	First sentence should end with a period.	58
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	61
Error	misc	FinalParameters	Parameter language should be final.	61
Error	javadoc	JavadocMethod	Expected @param tag for 'language'.	61
Error	misc	FinalParameters	Parameter model should be final.	61
Error	javadoc	JavadocMethod	Expected @param tag for 'model'.	61
Error	sizes	LineLength	Line is longer than 80 characters (found 93).	64
Error	design	DesignForExtension	Class 'View' looks like designed for extension (can be subclassed), but the method 'makeScene' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'View' final or making the method 'makeScene' static/final/abstract/empty, or adding allowed annotation for the method.	70
Error	javadoc	MissingJavadocMethod	Missing a Javadoc comment.	70
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	70
Error	misc	FinalParameters	Parameter width should be final.	70
Error	misc	FinalParameters	Parameter height should be final.	70
Error	sizes	LineLength	Line is longer than 80 characters (found 81).	88
Error	coding	MagicNumber	'50' is a magic number.	90
Error	coding	MagicNumber	'100' is a magic number.	90
Error	coding	MagicNumber	'100' is a magic number.	95
Error	coding	MagicNumber	'325' is a magic number.	95
Error	coding	MagicNumber	'20' is a magic number.	95
Error	coding	MagicNumber	'3' is a magic number.	101
Error	coding	MagicNumber	'4' is a magic number.	102
Error	coding	MagicNumber	'5' is a magic number.	103
Error	coding	MagicNumber	'6' is a magic number.	104
Error	coding	MagicNumber	'7' is a magic number.	105
Error	coding	MagicNumber	'7' is a magic number.	106
Error	sizes	LineLength	Line is longer than 80 characters (found 96).	110
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	115
Error	misc	FinalParameters	Parameter message should be final.	115
Error	sizes	LineLength	Line is longer than 80 characters (found 83).	123
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	123
Error	misc	FinalParameters	Parameter property should be final.	123
Error	misc	FinalParameters	Parameter response should be final.	123
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	130
Error	misc	FinalParameters	Parameter property should be final.	130
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	136
Error	misc	FinalParameters	Parameter id should be final.	136
Error	misc	FinalParameters	Parameter response should be final.	136
Error	whitespace	WhitespaceAfter	'typecast' is not followed by whitespace.	139
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	142
Error	misc	FinalParameters	Parameter buttons should be final.	142
Error	whitespace	NoWhitespaceBefore	'...' is preceded with whitespace.	142
Error	sizes	LineLength	Line is longer than 80 characters (found 94).	149
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	149
Error	misc	FinalParameters	Parameter id should be final.	149
Error	misc	FinalParameters	Parameter defaultChoice should be final.	149
Error	misc	FinalParameters	Parameter response should be final.	149
Error	sizes	LineLength	Line is longer than 80 characters (found 97).	155
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	155
Error	misc	FinalParameters	Parameter id should be final.	155
Error	misc	FinalParameters	Parameter min should be final.	155
Error	misc	FinalParameters	Parameter start should be final.	155
Error	misc	FinalParameters	Parameter max should be final.	155
Error	misc	FinalParameters	Parameter response should be final.	155
Error	sizes	LineLength	Line is longer than 80 characters (found 108).	160
Error	sizes	LineLength	Line is longer than 80 characters (found 99).	165
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	165
Error	misc	FinalParameters	Parameter id should be final.	165
Error	misc	FinalParameters	Parameter choices should be final.	165
Error	misc	FinalParameters	Parameter response should be final.	165
Error	sizes	LineLength	Line is longer than 80 characters (found 96).	166
Error	sizes	LineLength	Line is longer than 80 characters (found 98).	169
Error	sizes	LineLength	Line is longer than 80 characters (found 127).	172
Error	sizes	LineLength	Line is longer than 80 characters (found 112).	178
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	178
Error	misc	FinalParameters	Parameter idPrefix should be final.	178
Error	misc	FinalParameters	Parameter choices should be final.	178
Error	misc	FinalParameters	Parameter response should be final.	178
Error	sizes	LineLength	Line is longer than 80 characters (found 163).	190
Error	whitespace	WhitespaceAfter	'typecast' is not followed by whitespace.	190
Error	sizes	LineLength	Line is longer than 80 characters (found 110).	195
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	195
Error	misc	FinalParameters	Parameter idPrefix should be final.	195
Error	misc	FinalParameters	Parameter choices should be final.	195
Error	misc	FinalParameters	Parameter response should be final.	195
Error	sizes	LineLength	Line is longer than 80 characters (found 140).	200
Error	sizes	LineLength	Line is longer than 80 characters (found 106).	206
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	206
Error	misc	FinalParameters	Parameter id should be final.	206
Error	misc	FinalParameters	Parameter width should be final.	206
Error	misc	FinalParameters	Parameter height should be final.	206
Error	misc	FinalParameters	Parameter shapeSize should be final.	206
Error	misc	FinalParameters	Parameter response should be final.	206
Error	whitespace	WhitespaceAfter	',' is not followed by whitespace.	208
Error	whitespace	WhitespaceAfter	'typecast' is not followed by whitespace.	210
Error	whitespace	WhitespaceAfter	'typecast' is not followed by whitespace.	211
Error	sizes	LineLength	Line is longer than 80 characters (found 82).	224
Error	misc	FinalParameters	Parameter inputField should be final.	224
Error	misc	FinalParameters	Parameter response should be final.	224
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	229
Error	misc	FinalParameters	Parameter prompt should be final.	229
Error	misc	FinalParameters	Parameter response should be final.	229
Error	sizes	LineLength	Line is longer than 80 characters (found 96).	230
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	238
Error	misc	FinalParameters	Parameter dataFile should be final.	238
Error	misc	FinalParameters	Parameter response should be final.	238
Error	sizes	LineLength	Line is longer than 80 characters (found 106).	240
Error	design	DesignForExtension	Class 'View' looks like designed for extension (can be subclassed), but the method 'loadDataFile' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'View' final or making the method 'loadDataFile' static/final/abstract/empty, or adding allowed annotation for the method.	245
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	245
Error	misc	FinalParameters	Parameter dataFile should be final.	245
Error	sizes	LineLength	Line is longer than 80 characters (found 108).	247
Error	sizes	LineLength	Line is longer than 80 characters (found 94).	250
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	256
Error	misc	FinalParameters	Parameter n should be final.	256
Error	naming	LocalFinalVariableName	Name 'CSS_CLASS' must match pattern '^[a-z][a-zA-Z0-9]*$'.	257
Error	blocks	RightCurly	'}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).	261
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	268
Error	misc	FinalParameters	Parameter id should be final.	268
Error	misc	FinalParameters	Parameter node should be final.	268
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	274
Error	misc	FinalParameters	Parameter lbl should be final.	274
Error	misc	FinalParameters	Parameter txt should be final.	274

example/ViewEnglish.properties

Severity	Category	Rule	Message	Line
Error	regexp	RegexpSingleline	Line has trailing spaces.	5

money/Money.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocStyle	First sentence should end with a period.	4
Error	javadoc	JavadocMethod	@return tag should be present and have description.	14
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	14
Error	javadoc	JavadocMethod	Expected @param tag for 'm'.	14
Error	javadoc	JavadocMethod	@return tag should be present and have description.	19
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	19
Error	javadoc	JavadocMethod	Expected @param tag for 'm'.	19
Error	javadoc	JavadocMethod	@return tag should be present and have description.	24
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	24
Error	javadoc	JavadocMethod	Expected @param tag for 'factor'.	24
Error	javadoc	JavadocMethod	@return tag should be present and have description.	29
Error	javadoc	JavadocStyle	First sentence should end with a period.	31
Error	javadoc	JavadocMethod	@return tag should be present and have description.	34
Error	sizes	LineLength	Line is longer than 80 characters (found 119).	39
Error	javadoc	JavadocMethod	@return tag should be present and have description.	41
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	41
Error	javadoc	JavadocMethod	Expected @param tag for 'm'.	41
Error	sizes	LineLength	Line is longer than 80 characters (found 119).	46
Error	javadoc	JavadocMethod	@return tag should be present and have description.	48
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	48
Error	javadoc	JavadocMethod	Expected @param tag for 's'.	48

money/MoneyBag.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	20
Error	javadoc	JavadocStyle	First sentence should end with a period.	22
Error	sizes	LineLength	Line is longer than 80 characters (found 97).	23
Error	javadoc	JavadocMethod	@return tag should be present and have description.	27
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	27
Error	misc	FinalParameters	Parameter monies should be final.	27
Error	whitespace	NoWhitespaceBefore	'...' is preceded with whitespace.	27
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	38
Error	coding	MagicNumber	'5' is a magic number.	39
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	45
Error	misc	FinalParameters	Parameter copy should be final.	45
Error	javadoc	JavadocMethod	Expected @param tag for 'copy'.	45
Error	sizes	LineLength	Line is longer than 80 characters (found 97).	53
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	56
Error	misc	FinalParameters	Parameter m should be final.	56
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	64
Error	misc	FinalParameters	Parameter m should be final.	64
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	72
Error	misc	FinalParameters	Parameter factor should be final.	72
Error	sizes	LineLength	Line is longer than 80 characters (found 84).	76
Error	whitespace	WhitespaceAfter	'typecast' is not followed by whitespace.	77
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	87
Error	whitespace	WhitespaceAfter	'typecast' is not followed by whitespace.	91
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	100
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	108
Error	misc	FinalParameters	Parameter anObject should be final.	108
Error	whitespace	WhitespaceAfter	'typecast' is not followed by whitespace.	110
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	130
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	142
Error	sizes	LineLength	Line is longer than 80 characters (found 92).	152
Error	design	DesignForExtension	Class 'MoneyBag' looks like designed for extension (can be subclassed), but the method 'addMoney' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoneyBag' final or making the method 'addMoney' static/final/abstract/empty, or adding allowed annotation for the method.	153
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	154
Error	misc	FinalParameters	Parameter simple should be final.	154
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	160
Error	misc	FinalParameters	Parameter aSimpleMoney should be final.	160
Error	whitespace	WhitespaceAfter	'typecast' is not followed by whitespace.	171
Error	design	DesignForExtension	Class 'MoneyBag' looks like designed for extension (can be subclassed), but the method 'addMoneyBag' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MoneyBag' final or making the method 'addMoneyBag' static/final/abstract/empty, or adding allowed annotation for the method.	178
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	179
Error	misc	FinalParameters	Parameter bag should be final.	179
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	185
Error	misc	FinalParameters	Parameter aBag should be final.	185
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	192
Error	misc	FinalParameters	Parameter currency should be final.	192
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	202
Error	misc	FinalParameters	Parameter m should be final.	202
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	209

money/SimpleMoney.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocPackage	Missing package-info.java file.	1
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	10
Error	javadoc	JavadocVariable	Missing a Javadoc comment.	11
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	17
Error	misc	FinalParameters	Parameter amount should be final.	17
Error	javadoc	JavadocMethod	Expected @param tag for 'amount'.	17
Error	misc	FinalParameters	Parameter currency should be final.	17
Error	javadoc	JavadocMethod	Expected @param tag for 'currency'.	17
Error	sizes	LineLength	Line is longer than 80 characters (found 97).	25
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	28
Error	misc	FinalParameters	Parameter m should be final.	28
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	36
Error	misc	FinalParameters	Parameter m should be final.	36
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	44
Error	misc	FinalParameters	Parameter factor should be final.	44
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	52
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	60
Error	javadoc	JavadocMethod	@return tag should be present and have description.	67
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	67
Error	javadoc	JavadocMethod	@return tag should be present and have description.	74
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	74
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	82
Error	misc	FinalParameters	Parameter anObject should be final.	82
Error	whitespace	WhitespaceAround	'&&' is not followed by whitespace.	84
Error	sizes	LineLength	Line is longer than 80 characters (found 99).	87
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	96
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	107
Error	design	DesignForExtension	Class 'SimpleMoney' looks like designed for extension (can be subclassed), but the method 'addMoney' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SimpleMoney' final or making the method 'addMoney' static/final/abstract/empty, or adding allowed annotation for the method.	113
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	114
Error	misc	FinalParameters	Parameter m should be final.	114
Error	design	DesignForExtension	Class 'SimpleMoney' looks like designed for extension (can be subclassed), but the method 'addMoneyBag' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SimpleMoney' final or making the method 'addMoneyBag' static/final/abstract/empty, or adding allowed annotation for the method.	121
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	122
Error	misc	FinalParameters	Parameter s should be final.	122

reflection/ShowClass.java

Severity	Category	Rule	Message	Line
Error	javadoc	JavadocPackage	Missing package-info.java file.	1
Error	design	HideUtilityClassConstructor	Utility classes should not have a public or default constructor.	26
Error	sizes	LineLength	Line is longer than 80 characters (found 94).	28
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	30
Error	misc	FinalParameters	Parameter clazz should be final.	30
Error	javadoc	JavadocMethod	Expected @param tag for 'clazz'.	30
Error	blocks	RightCurly	'}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).	39
Error	sizes	LineLength	Line is longer than 80 characters (found 119).	40
Error	sizes	LineLength	Line is longer than 80 characters (found 82).	47
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	50
Error	misc	FinalParameters	Parameter c should be final.	50
Error	javadoc	JavadocMethod	Expected @param tag for 'c'.	50
Error	whitespace	OperatorWrap	'+' should be on a new line.	54
Error	sizes	LineLength	Line is longer than 80 characters (found 82).	55
Error	whitespace	OperatorWrap	'+' should be on a new line.	56
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	85
Error	misc	FinalParameters	Parameter f should be final.	85
Error	sizes	LineLength	Line is longer than 80 characters (found 106).	91
Error	sizes	LineLength	Line is longer than 80 characters (found 97).	94
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	95
Error	misc	FinalParameters	Parameter member should be final.	95
Error	sizes	LineLength	Line is longer than 80 characters (found 87).	121
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	121
Error	misc	FinalParameters	Parameter annotations should be final.	121
Error	misc	FinalParameters	Parameter delimiter should be final.	121
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	128
Error	misc	FinalParameters	Parameter types should be final.	128
Error	regexp	RegexpSingleline	Line has trailing spaces.	141
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	143
Error	misc	FinalParameters	Parameter t should be final.	143
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	153
Error	misc	FinalParameters	Parameter m should be final.	153
Error	javadoc	MissingJavadocMethod	Missing a Javadoc comment.	159
Error	whitespace	MethodParamPad	'(' is preceded with whitespace.	159
Error	misc	FinalParameters	Parameter args should be final.	159
Error	sizes	LineLength	Line is longer than 80 characters (found 89).	160